Fix Next.js 13 host being stubborn when relying on req.url
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d867ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Nov 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#409](#409) [`b56a33e`](b56a33e) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Support Remix env vars on Cloudflare Pages via `context.env` - [#400](#400) [`428a591`](428a591) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix Next.js 13 host being stubborn when relying on `req.url` for hosts such as `host.docker.internal` - [#408](#408) [`4066217`](4066217) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Forward `X-Inngest-Server-Kind` headers to assist in preventing some issues with registration handshakes - [#406](#406) [`be5544b`](be5544b) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix correctness issues in generated `*.d.ts` files, causing errors for some versions/configurations of TypeScript with `skipLibCheck: false` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
jpwilliams
added a commit
that referenced
this pull request
Dec 12, 2023
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> Next.js versions `next@>=13.0.0 <13.5.0` will throw an error if a `Response` object is returned from a serverless endpoint. `next@>=13.5.0` will display the error but continue to function. Next.js edge still requires that the `ReturnType` of the function is a `Response`, so we keep that type whilst ensuring it's not actually passed back in serverless endpoints. There are so many edge cases here and this one breaks across minor versions. Separate exports (e.g. `inngest/next-13-edge`) might be appropriate in the future if the type/runtime guards continue to become stricter on the Next.js side. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~~Added a [docs PR](https://github.com/inngest/website) that references this PR~~ N/A Bug fix - [ ] ~~Added unit/integration tests~~ N/A Will observe logs disappearing in current integration tests which use `[email protected]`: https://github.com/inngest/inngest-js/actions/runs/7181668471/job/19556571083?pr=421 - [x] Added changesets if applicable ## Related <!-- A space for any related links, issues, or PRs. --> <!-- Linear issues are autolinked. --> <!-- e.g. - INN-123 --> <!-- GitHub issues/PRs can be linked using shorthand. --> <!-- e.g. "- inngest/inngest#123" --> <!-- Feel free to remove this section if there are no applicable related links.--> - #400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After debugging with #391, this PR fixes Next.js 13 sometimes being very stubborn when we want to rely on its
req.urlproperty.Checklist
Added a docs PR that references this PRN/A Bug fixAdded unit/integration testsN/ARelated
_unsafe_debugflag to serve options #391 for debugging - closing this